summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormo8it <mo8it@proton.me>2024-11-13 16:06:41 +0100
committermo8it <mo8it@proton.me>2024-11-13 16:06:41 +0100
commit38016cb2d6053c7d4f18c7ca98880a3ac7d392fa (patch)
tree0ca288aa8fe7a69160b197d757237c2a8c25bd01
parente6cb1042946816a6ac835cf1f15a71898bdf4ed6 (diff)
clippy3: Make the intent more clear
-rw-r--r--exercises/22_clippy/clippy3.rs6
-rw-r--r--solutions/22_clippy/clippy3.rs4
2 files changed, 6 insertions, 4 deletions
diff --git a/exercises/22_clippy/clippy3.rs b/exercises/22_clippy/clippy3.rs
index 4f78834..7a3cb39 100644
--- a/exercises/22_clippy/clippy3.rs
+++ b/exercises/22_clippy/clippy3.rs
@@ -4,9 +4,11 @@
#[rustfmt::skip]
#[allow(unused_variables, unused_assignments)]
fn main() {
- let my_option: Option<()> = None;
+ let my_option: Option<&str> = None;
+ // Assume that you don't know the value of `my_option`.
+ // In the case of `Some`, we want to print its value.
if my_option.is_none() {
- println!("{:?}", my_option.unwrap());
+ println!("{}", my_option.unwrap());
}
let my_arr = &[
diff --git a/solutions/22_clippy/clippy3.rs b/solutions/22_clippy/clippy3.rs
index 811d184..b7eaa57 100644
--- a/solutions/22_clippy/clippy3.rs
+++ b/solutions/22_clippy/clippy3.rs
@@ -3,11 +3,11 @@ use std::mem;
#[rustfmt::skip]
#[allow(unused_variables, unused_assignments)]
fn main() {
- let my_option: Option<()> = None;
+ let my_option: Option<&str> = None;
// `unwrap` of an `Option` after checking if it is `None` will panic.
// Use `if-let` instead.
if let Some(value) = my_option {
- println!("{value:?}");
+ println!("{value}");
}
// A comma was missing.