diff options
| author | bors <bors@rust-lang.org> | 2019-11-11 15:59:35 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2019-11-11 15:59:35 +0000 |
| commit | 88ec6f6b1645599f77643ee5e6f5dd16cd67c943 (patch) | |
| tree | 36442292a4e3b0ae07072b0dfaf59a3bc799a397 /exercises/error_handling/errors2.rs | |
| parent | a47a62172a5d4c479d242498b9b140b3111fb7c6 (diff) | |
| parent | 2cdd61294f0d9a53775ee24ad76435bec8a21e60 (diff) | |
Auto merge of #230 - jrvidal:master, r=fmoko
Changes the execution mode for `watch`, asking for user input
We've [observed](https://hackmd.io/-cK6aPhnTwiCiI7u6k0xug?both) that learners can get confused when they do get everything right, but they _still_ get errors... which come from the next exercise, no the one they just edited.
This PR changes it so they have to confirm they want to move forward by removing the `I AM NOT DONE` comment.
* [ ] The particular string is of course subject to bikeshed.
### Alternatives/doubts
* The coolest solution I could imagine would involve a proc-macro attribute `#![ready(false)]` that they could edit once they're done, but it's a bit complicated to set up.
* For now I've put `I AM NOT DONE` everywhere, I think it's what make more sense.
Diffstat (limited to 'exercises/error_handling/errors2.rs')
| -rw-r--r-- | exercises/error_handling/errors2.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/exercises/error_handling/errors2.rs b/exercises/error_handling/errors2.rs index 8b81207..315528f 100644 --- a/exercises/error_handling/errors2.rs +++ b/exercises/error_handling/errors2.rs @@ -16,6 +16,8 @@ // There are at least two ways to implement this that are both correct-- but // one is a lot shorter! Scroll down for hints to both ways. +// I AM NOT DONE + use std::num::ParseIntError; pub fn total_cost(item_quantity: &str) -> Result<i32, ParseIntError> { |