diff options
| author | bors <bors@rust-lang.org> | 2019-11-11 15:59:35 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2019-11-11 15:59:35 +0000 |
| commit | 88ec6f6b1645599f77643ee5e6f5dd16cd67c943 (patch) | |
| tree | 36442292a4e3b0ae07072b0dfaf59a3bc799a397 /exercises/tests | |
| parent | a47a62172a5d4c479d242498b9b140b3111fb7c6 (diff) | |
| parent | 2cdd61294f0d9a53775ee24ad76435bec8a21e60 (diff) | |
Auto merge of #230 - jrvidal:master, r=fmoko
Changes the execution mode for `watch`, asking for user input
We've [observed](https://hackmd.io/-cK6aPhnTwiCiI7u6k0xug?both) that learners can get confused when they do get everything right, but they _still_ get errors... which come from the next exercise, no the one they just edited.
This PR changes it so they have to confirm they want to move forward by removing the `I AM NOT DONE` comment.
* [ ] The particular string is of course subject to bikeshed.
### Alternatives/doubts
* The coolest solution I could imagine would involve a proc-macro attribute `#![ready(false)]` that they could edit once they're done, but it's a bit complicated to set up.
* For now I've put `I AM NOT DONE` everywhere, I think it's what make more sense.
Diffstat (limited to 'exercises/tests')
| -rw-r--r-- | exercises/tests/tests1.rs | 2 | ||||
| -rw-r--r-- | exercises/tests/tests2.rs | 2 | ||||
| -rw-r--r-- | exercises/tests/tests3.rs | 2 |
3 files changed, 6 insertions, 0 deletions
diff --git a/exercises/tests/tests1.rs b/exercises/tests/tests1.rs index b11221f..1465e37 100644 --- a/exercises/tests/tests1.rs +++ b/exercises/tests/tests1.rs @@ -6,6 +6,8 @@ // This test has a problem with it -- make the test compile! Make the test // pass! Make the test fail! Scroll down for hints :) +// I AM NOT DONE + #[cfg(test)] mod tests { #[test] diff --git a/exercises/tests/tests2.rs b/exercises/tests/tests2.rs index 6775d61..81e30e0 100644 --- a/exercises/tests/tests2.rs +++ b/exercises/tests/tests2.rs @@ -2,6 +2,8 @@ // This test has a problem with it -- make the test compile! Make the test // pass! Make the test fail! Scroll down for hints :) +// I AM NOT DONE + #[cfg(test)] mod tests { #[test] diff --git a/exercises/tests/tests3.rs b/exercises/tests/tests3.rs index e10d2aa..af48095 100644 --- a/exercises/tests/tests3.rs +++ b/exercises/tests/tests3.rs @@ -3,6 +3,8 @@ // the test passes. Then write a second test that tests whether we get the result // we expect to get when we call `is_even(5)`. Scroll down for hints! +// I AM NOT DONE + pub fn is_even(num: i32) -> bool { num % 2 == 0 } |