summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--exercises/tests/tests4.rs11
-rw-r--r--info.toml5
2 files changed, 11 insertions, 5 deletions
diff --git a/exercises/tests/tests4.rs b/exercises/tests/tests4.rs
index 2d8dd13..727dbd7 100644
--- a/exercises/tests/tests4.rs
+++ b/exercises/tests/tests4.rs
@@ -1,6 +1,5 @@
// tests4.rs
-// Correct the tests to
-// Do not change Rectangle::new body
+// Make sure that we're testing for the correct conditions!
// Execute `rustlings hint tests4` or use the `hint` watch subcommand for a hint.
// I AM NOT DONE
@@ -11,6 +10,7 @@ struct Rectangle {
}
impl Rectangle {
+ // Only change the test functions themselves
pub fn new(width: i32, height: i32) -> Self {
if width < 0 || height < 0 {
panic!("Rectangle width and height cannot be negative!")
@@ -25,16 +25,21 @@ mod tests {
#[test]
fn correct_width_and_height() {
- let _rect = Rectangle::new(10, 10);
+ // This test should check if the rectangle is the size that we pass into its constructor
+ let rect = Rectangle::new(10, 20);
+ assert_eq!(???, 10); // check width
+ assert_eq!(???, 20); // check height
}
#[test]
fn negative_width() {
+ // This test should check if thread panics when we try to create rectangle with negative width
let _rect = Rectangle::new(-10, 10);
}
#[test]
fn negative_height() {
+ // This test should check if thread panics when we try to create rectangle with negative height
let _rect = Rectangle::new(10, -10);
}
}
diff --git a/info.toml b/info.toml
index ad06b88..fe79bde 100644
--- a/info.toml
+++ b/info.toml
@@ -813,8 +813,9 @@ path = "exercises/tests/tests4.rs"
mode = "test"
hint = """
We expect method `Rectangle::new()` to panic for negative values.
-To handle that you need to add special attribute to test function.
-You can refer to the docs: https://doc.rust-lang.org/stable/book/ch11-01-writing-tests.html"""
+To handle that you need to add a special attribute to the test function.
+You can refer to the docs:
+https://doc.rust-lang.org/stable/book/ch11-01-writing-tests.html#checking-for-panics-with-should_panic"""
# STANDARD LIBRARY TYPES