summaryrefslogtreecommitdiff
path: root/exercises/22_clippy
diff options
context:
space:
mode:
Diffstat (limited to 'exercises/22_clippy')
-rw-r--r--exercises/22_clippy/clippy1.rs25
-rw-r--r--exercises/22_clippy/clippy2.rs11
-rw-r--r--exercises/22_clippy/clippy3.rs17
3 files changed, 17 insertions, 36 deletions
diff --git a/exercises/22_clippy/clippy1.rs b/exercises/22_clippy/clippy1.rs
index 95c0141..7165da4 100644
--- a/exercises/22_clippy/clippy1.rs
+++ b/exercises/22_clippy/clippy1.rs
@@ -1,26 +1,15 @@
-// clippy1.rs
-//
// The Clippy tool is a collection of lints to analyze your code so you can
// catch common mistakes and improve your Rust code.
//
-// For these exercises the code will fail to compile when there are clippy
-// warnings check clippy's suggestions from the output to solve the exercise.
-//
-// Execute `rustlings hint clippy1` or use the `hint` watch subcommand for a
-// hint.
-
-// I AM NOT DONE
-
-use std::f32;
+// For these exercises, the code will fail to compile when there are Clippy
+// warnings. Check Clippy's suggestions from the output to solve the exercise.
fn main() {
- let pi = 3.14f32;
- let radius = 5.00f32;
+ // TODO: Fix the Clippy lint in this line.
+ let pi = 3.14;
+ let radius: f32 = 5.0;
- let area = pi * f32::powi(radius, 2);
+ let area = pi * radius.powi(2);
- println!(
- "The area of a circle with radius {:.2} is {:.5}!",
- radius, area
- )
+ println!("The area of a circle with radius {radius:.2} is {area:.5}");
}
diff --git a/exercises/22_clippy/clippy2.rs b/exercises/22_clippy/clippy2.rs
index 9b87a0b..8cfe6f8 100644
--- a/exercises/22_clippy/clippy2.rs
+++ b/exercises/22_clippy/clippy2.rs
@@ -1,15 +1,10 @@
-// clippy2.rs
-//
-// Execute `rustlings hint clippy2` or use the `hint` watch subcommand for a
-// hint.
-
-// I AM NOT DONE
-
fn main() {
let mut res = 42;
let option = Some(12);
+ // TODO: Fix the Clippy lint.
for x in option {
res += x;
}
- println!("{}", res);
+
+ println!("{res}");
}
diff --git a/exercises/22_clippy/clippy3.rs b/exercises/22_clippy/clippy3.rs
index 5a95f5b..4f78834 100644
--- a/exercises/22_clippy/clippy3.rs
+++ b/exercises/22_clippy/clippy3.rs
@@ -1,30 +1,27 @@
-// clippy3.rs
-//
-// Here's a couple more easy Clippy fixes, so you can see its utility.
-// No hints.
-
-// I AM NOT DONE
+// Here are some more easy Clippy fixes so you can see its utility 📎
+// TODO: Fix all the Clippy lints.
+#[rustfmt::skip]
#[allow(unused_variables, unused_assignments)]
fn main() {
let my_option: Option<()> = None;
if my_option.is_none() {
- my_option.unwrap();
+ println!("{:?}", my_option.unwrap());
}
let my_arr = &[
-1, -2, -3
-4, -5, -6
];
- println!("My array! Here it is: {:?}", my_arr);
+ println!("My array! Here it is: {my_arr:?}");
let my_empty_vec = vec![1, 2, 3, 4, 5].resize(0, 5);
- println!("This Vec is empty, see? {:?}", my_empty_vec);
+ println!("This Vec is empty, see? {my_empty_vec:?}");
let mut value_a = 45;
let mut value_b = 66;
// Let's swap these two!
value_a = value_b;
value_b = value_a;
- println!("value a: {}; value b: {}", value_a, value_b);
+ println!("value a: {value_a}; value b: {value_b}");
}